Fix compiler warnings across project - #422
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #422 +/- ##
==========================================
+ Coverage 67.55% 67.88% +0.32%
==========================================
Files 8 8
Lines 299 302 +3
Branches 5 6 +1
==========================================
+ Hits 202 205 +3
Misses 97 97
Continue to review full report at Codecov.
|
rafaparadela
approved these changes
Jan 14, 2021
rafaparadela
left a comment
rafaparadela
left a comment
There was a problem hiding this comment.
Not sure about the explicit casting, but as long as removing compilation warnings is the motivation, I'm ok with that :-)
Thanks for the efforts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some code used features of Scala or http4s that either were deprecated, or confused the compiler while being technically usable. This tweaks the code that's there just enough to get it all working without warnings.
.fetchsyntax is deprecated, replaced w/.run.use?with*for kind projector usage